Conversation
…creating a workflow/workflow instance. Closes #517 Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
JBBianchi
added
type: enhancement
…w details view Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to specify a target operator when creating workflows and workflow instances, addressing issue #517. The implementation includes a dropdown selector in both workflow and workflow instance creation forms, allowing users to choose from available operators or select "Any Operator" for default behavior.
Key changes include:
- Added operator selection UI components with dropdowns in creation forms
- Extended data models and state management to support operator filtering and selection
- Modified workflow/instance creation logic to apply operator labels when specified
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Synapse.Dashboard.csproj | Updates Blazor.Bootstrap package version |
| Pages/Workflows/List/View.razor | Removes "this" qualifiers for cleaner code style |
| Pages/Workflows/List/Store.cs | Removes unused import and applies code style improvements |
| Pages/Workflows/Details/View.razor | Adds operator selection support to workflow instance management |
| Pages/Workflows/Details/Store.cs | Extends store with operator management and updates instance creation |
| Pages/Workflows/Details/State.cs | Adds operator-related state properties |
| Pages/Workflows/Create/View.razor | Adds operator selection dropdown to workflow creation form |
| Pages/Workflows/Create/Store.cs | Implements operator management and applies labels during workflow creation |
| Pages/Workflows/Create/State.cs | Extends state with operator properties |
| CreateWorkflowInstanceParameters.cs | New record for encapsulating instance creation parameters |
| CreateWorkflowInstanceDialog.razor | Adds operator selection to instance creation dialog |
Comments suppressed due to low confidence (5)
src/dashboard/Synapse.Dashboard/Pages/Workflows/Details/Store.cs:563
- The variable name 'api' should follow consistent naming conventions. It should be 'Api' to match the naming pattern used elsewhere in the file.
await TextEditor.SetSelection(range, string.Empty);
src/dashboard/Synapse.Dashboard/Pages/Workflows/Details/View.razor:175
- Property name 'operators' should follow C# naming conventions and be PascalCase. It should be 'Operators'.
protected EquatableList<Operator>? operators { get; set; }
src/dashboard/Synapse.Dashboard/Pages/Workflows/Details/View.razor:176
- Property name 'operatorName' should follow C# naming conventions and be PascalCase. It should be 'OperatorName'.
protected string? operatorName { get; set; }
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor:101
- Property name 'operators' should follow C# naming conventions and be PascalCase. It should be 'Operators'.
protected EquatableList<Operator>? operators { get; set; }
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor:102
- Property name 'operatorName' should follow C# naming conventions and be PascalCase. It should be 'OperatorName'.
protected string? operatorName { get; set; }
...Synapse.Dashboard/Components/CreateWorkflowInstanceDialog/CreateWorkflowInstanceDialog.razor
Show resolved
Hide resolved
…properties Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Closes Add possibility to specify the target operator when creating a new workflow and/or workflow instance #517